[BUGFIX] Preserve CType group labels when using allowed#155
Open
derhansen wants to merge 2 commits intoIchHabRecht:mainfrom
Open
[BUGFIX] Preserve CType group labels when using allowed#155derhansen wants to merge 2 commits intoIchHabRecht:mainfrom
allowed#155derhansen wants to merge 2 commits intoIchHabRecht:mainfrom
Conversation
This change ensures, that item group labels are left out when filtering the `allowed` array of CType items. Closes IchHabRecht#149
derhansen
changed the title
allowedallowed
IchHabRecht
reviewed
May 31, 2024
This change ensures, that item group labels are left out when filtering the `allowed` array of CType items. Closes IchHabRecht#149
|
At first glance, this solution works. Would it be possible to do a merge and a release? |
|
I can confirm that the patch works under 13.4.23 and content_defender 3.5.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures, that item group labels are left out when filtering the
allowedarray of CType items.Closes #149